[FFmpeg-devel] [PATCH] Maximum number of frames in an RTP packet

[Michael Niedermayer]

Hi

On Wed, Sep 26, 2007 at 02:37:47PM +0200, Luca Abeni wrote:
> Hi Michael,
> 
> Michael Niedermayer wrote:
> [...]
> >> +    s->max_frames_per_packet = 0;
> >> +    if (s1->max_delay) {
> >> +        if (st->codec->codec_type == CODEC_TYPE_AUDIO) {
> >> +            if (st->codec->frame_size == 0) {
> >> +                av_log(s1, AV_LOG_ERROR, "Cannot respect max delay: frame size = 0\n");
> >> +            } else {
> >> +                s->max_frames_per_packet = av_rescale(s1->max_delay, st->codec->sample_rate, AV_TIME_BASE * st->codec->frame_size);
> > 
> > this should use av_rescale_rnd() if you want max_delay strictly followed
> Thanks; I did not notice that av_rescale() rounds to the nearest.
> 
> > and the patch looks mostly ok (didnt review to carefull...)
> > but iam not rtp maintainer ...
> Well, I think part of the problem is that we have no RTP maintainer ;-)
> I was going to propose myself as a maintainer for the RTP muxer, hoping
> that someone else can take care of the demuxer...

add yourself to MAINTAINERS ...

i already now know i will be deeply confused by
luca a. maintaining rtp and luca b. maintaining rtsp :)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070926/00c7f8d8/attachment.pgp>