[FFmpeg-devel] Check on line 2616 h264.c redundant?

Panagiotis Issaris takis.issaris
Thu Sep 27 11:39:04 CEST 2007


On line 2616 of h264.c the following occurs:
h264_luma_dc_dequant_idct_c(h->mb, s->qscale,
h->dequant4_coeff[IS_INTRA(mb_type) ? 0:3][s->qscale][0]);

But, this line appears within a if(IS_INTRA(mb_type)) block. To me it
seems like it is redundant as the code which is executed between this
test and line 2616 only contains xchg_mb_border and some prediction code.

So, is the test redundant or am I missing something?

With friendly regards,
vCard: http://www.issaris.org/pi.vcf
Public key: http://www.issaris.org/pi.key
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070927T105100-ffmpeg-h264_redundant_check.diff
Type: text/x-patch
Size: 729 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070927/28db7f90/attachment.bin>

More information about the ffmpeg-devel mailing list