[FFmpeg-devel] [PATCH] read metadata in FLAC demuxer
Sun Sep 30 20:47:18 CEST 2007
Michael Niedermayer wrote:
> On Sun, Sep 30, 2007 at 12:48:08AM -0400, Justin Ruggles wrote:
>> Here is a patch to fix issue 187 in the FFmpeg Issue Tracker, "flac decoder
>> fails with large metadata".
>> For raw FLAC files, the metadata header(s) are read in the demuxer rather
>> than the decoder. This correctly skips any irrelevant metadata blocks, and
>> it also parses vorbiscomment info.
> what happens with flac in avi and matroska ?
True, it should be handled in those demuxers as well. And I do see your
point as far as code duplication. I'm working on a better solution with
shared code between the decoder and all the demuxers.
>> + /* create AVStream */
>> st = av_new_stream(s, 0);
yep. I'll remove it.
More information about the ffmpeg-devel