[FFmpeg-devel] [RFC] support for Cam_PAL_D1_inter_Field_25fps_2.5MBS.mp4

Reimar Döffinger Reimar.Doeffinger
Tue Apr 1 01:08:26 CEST 2008


On Tue, Apr 01, 2008 at 12:47:21AM +0200, Michael Niedermayer wrote:
> On Wed, Mar 26, 2008 at 09:57:35AM +0100, Reimar D?ffinger wrote:
> > Hello,
> > On Wed, Mar 26, 2008 at 03:46:59AM +0100, Michael Niedermayer wrote:
> > > On Fri, Mar 21, 2008 at 01:50:47PM +0100, Reimar D?ffinger wrote:
> > > > @@ -7600,6 +7614,10 @@
> > > >               * NAL unit stuff to context 0 and restart. Note that
> > > >               * rbsp_buffer is not transfered, but since we no longer
> > > >               * run in parallel mode this should not be an issue. */
> > > > +            if(context_count) {
> > > > +                execute_decode_slices(h, context_count);
> > > > +                context_count = 0;
> > > > +            }
> > > 
> > > What values do context_count and h->max_contexts have here? and why
> > > does the 
> > > if(context_count == h->max_contexts) {
> > > above not trigger?
> > > 
> > > max_contexts should be 1 and context_count should be 1 as well i think
> > 
> > In this case yes, but my idea was that the code should also work and
> > decode in parallel if each field is coded into multiple slices.
> > Since I have no actual file to test that, I could have done nonsense I
> > admit...
> 
> I assume that all the other changes are actually needed or are there further
> that are just there because they could do some good in some hyphothetical case?

Probably they are necessary, but I do not know for sure. I was actually
hoping that this patch would be enough for someone with actual H.264
knowledge to take over. E.g. the sample file always has the bottom field
last, if that was always true, the available_fields context variable
would not be needed.

Greetings,
Reimar D?ffinger




More information about the ffmpeg-devel mailing list