[FFmpeg-devel] question about patch rtsp EPROTONOSUPPORT => AVERROR_INVALIDDATA

[pross at xvid.org]

On Tue, Apr 01, 2008 at 12:35:43PM +0200, Michael Niedermayer wrote:
> On Tue, Apr 01, 2008 at 09:15:32AM +0000, Johan Mellberg wrote:
> > Hi,
> > 
> > just a quick question: I currently manually apply the patch from http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2008-March/044249.html.
> > 
> > Any chance of that being applied to the trunk? 
> 
> > If not, why? 
> 
> i can only speak for myself:
> Iam not RTSP maintainer :)

There was an alternate suggestion to wrap EPROTONOSUPPORT with FF_NETWORK
to make rtsp.c compile with Winsock. Enclosed is a patch that implements
this _and_ provides the missing error message in cmdutils.c.

IMHO, it would be better to drop EPROTONOSUPPORT altogether, because it is
raised when the RTSP demuxer encouters an unknown/unsupported datatype. Many
existing format demuxers use AVERROR_INVALIDDATA to indicate this form of
error (that said RTSP isn't strictly a format).

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtsp-ffnetwork.diff
Type: text/x-diff
Size: 1113 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080401/a1869dd2/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080401/a1869dd2/attachment.pgp>