[FFmpeg-devel] [PATCH] [2/??] [3/3] Filter graphs - Parser for a graph description

Michael Niedermayer michaelni
Fri Apr 4 02:09:47 CEST 2008


On Thu, Apr 03, 2008 at 10:13:33PM +0200, Vitor Sessak wrote:
> Hi
>
> Michael Niedermayer wrote:
>> On Thu, Apr 03, 2008 at 06:54:29PM +0200, Vitor Sessak wrote:
>>> Hi, and thanks for the review
>> [...]
>>> (... review skipped ...)
>>>
>>> All good points. New version attached.
>> [...]
>>> void avfilter_graph_add_filter(AVFilterGraph *graph, AVFilterContext 
>>> *filter)
>>> {
>>>     graph->filters = av_realloc(graph->filters,
>>>                                 sizeof(AVFilterContext*) * 
>>> ++graph->filter_count);
>>>     graph->filters[graph->filter_count - 1] = filter;
>> Out of array write
>
> Could you elaborate? I'd agree if it were graph->filter_count++ and not 
> ++graph->filter_count...

av_realloc() can return NULL ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080404/d45abbfb/attachment.pgp>



More information about the ffmpeg-devel mailing list