[FFmpeg-devel] [PATCH]Add Dirac support to ffmpeg via libdirac_* and Schroedinger libraries]

[Michael Niedermayer]

On Thu, Apr 10, 2008 at 02:18:59PM +0200, Michael Niedermayer wrote:
> On Thu, Apr 10, 2008 at 03:14:41PM +1000, Anuradha Suraparaju wrote:
> > I'll be submitting a libdirac patch soon. But have some comments.
> > 
> > On Sat, 2008-04-05 at 01:44 +0200, Michael Niedermayer wrote:
> > 
> > 
> > > [...]
> > > 
> > > > diff --exclude=.svn -ruN ffmpegsvn_trunk/libavcodec/schroedinger.c ffmpegsvn_trunk_dirac_schro/libavcodec/schroedinger.c
> > > > --- ffmpegsvn_trunk/libavcodec/schroedinger.c	1970-01-01 10:00:00.000000000 +1000
> > > > +++ ffmpegsvn_trunk_dirac_schro/libavcodec/schroedinger.c	2008-04-04 11:29:00.000000000 +1000
> > > [...]
> > > > +/* contains a single encoded frame returned from Schroedinger */
> > > > +typedef struct FfmpegSchroOutputEncFrame
> > > > +{
> > > > +    /* frame data */
> > > > +    unsigned char *p_data;
> > > > +    
> > > > +    /* frame size */
> > > > +    int size;
> > > > +    
> > > > +    /* key frame flag */
> > > > +    int key_frame;
> > > > +    
> > > > +    /* next frame to be output in sequence */
> > > > +    struct FfmpegSchroOutputEncFrame *p_next_frame;
> > > > +    
> > > > + } FfmpegSchroOutputEncFrame;
> > > 
> > > code duplication relative to dirac
> > > 
> > 
> > I'd rather not have a common file containing code common to Dirac and
> > Schroedinger because that would mean both libraries will need to be
> > installed for successful build. So I'd like to keep them separate.
> 
> You could have a
> libdirac.c              (Depends on installed libdirac)
> libschro.c              (Depends on installed libschro)

I of course meant:
libdiracdec.c
libdiracenc.c
libschrodec.c
libschroenc.c


> dirac_schro_common.c    (Does not depend on either)
> dirac_schro_common.h    (Does not depend on either)
[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080410/84406a19/attachment.pgp>