[FFmpeg-devel] [PATCH] too late bounds check in mpeg1_decode_block_intra
Thu Apr 10 18:26:25 CEST 2008
On Thu, Apr 10, 2008 at 05:35:03PM +0200, Reimar D?ffinger wrote:
> someone on MPlayer-users seems to have problems due to this. While I
> can't test myself, the code seems obviously wrong to me.
> Attached is my suggestion to fix it, though there are other
> possibilities, like increasing the size of intra_scantable.permutated
> to 256 and maybe more.
First i dont see a problem and would thus like to see how exactly something
can go wrong. there are 64 entries (raster_end) after "permutated" and i dont
see how the code could read past them. Its maybe not beautifull but as long
as there is no bug iam against making to code more complex.
Second there are a dozen such routines you change just one.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel