[FFmpeg-devel] [PATCH] libvorbis codec repeats timestamp at EOF
Thu Apr 17 00:58:23 CEST 2008
On Thu, Apr 17, 2008 at 12:29:22AM +0200, Henrik Gulbrandsen wrote:
> Here's the second patch. To reproduce the problem, you must configure
> FFmpeg with --enable-libvorbis --disable-encoder=vorbis, since vorbis
> will otherwise always be used even if libvorbis is explicitly specified.
> There should probably be a warning that keeps people from configuring
> both encoders at the same time, but that is a slightly different issue.
> For ffmpeg -i audio.flac -acodec libvorbis audio.ogg the encoding ends
> with an error similar to this one:
> error, non monotone timestamps 7714944 >= 7714944
> av_interleaved_write_frame(): Error while opening file
> and the last few bytes of the file are never written. I traced this to a
> scenario where oggvorbis_encode_frame() is called multiple times with
> NULL data to flush the buffers, but libvorbis doesn't like to get EOF
> more than one time, so I simply added a check so it's only called once.
> P.S. Is there any chance that someone can either increase the verbosity
> level of the "Multiple frames in a packet" message, so it's not visible
> by default, or make it print just a single time? I guess the intention
> is to force people to refactor the FLAC codec, but with over 6000 lines
> of error messages, I'm more likely to simply use "-v 0" instead...
send a patch
the first should be at AV_LOG_WARNING level and subsequent ones could be
> Index: libavcodec/libvorbis.c
> --- libavcodec/libvorbis.c (revision 12867)
> +++ libavcodec/libvorbis.c (working copy)
i dont maintain libvorbis (so no review from me)
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel