[FFmpeg-devel] BFI video decoder

Sisir Koppaka sisir.koppaka
Thu Apr 17 23:55:59 CEST 2008


Updated patch attached

On Fri, Apr 18, 2008 at 3:12 AM, Michael Niedermayer <michaelni at gmx.at>
wrote:

> On Fri, Apr 18, 2008 at 03:01:25AM +0530, Sisir Koppaka wrote:
> > Patch attached (docs + code)
> > Couple of issues left:
> > 1. extradata_size check: what do we do if we find it's larger than
> data[1],
> > av_log+return -1?
>
> yes
>
Done

>
>
> > 2. This warning appears :
> >
> > bfi.c: In function 'bfi_decode_frame':
> > bfi.c:92: warning: 'offset' may be used uninitialized in this function
>
> ignore it
>
> ok

>
> [...]
> > +    uint8_t *src, *dst_offset, *frame_end = bfi->dst + avctx->width *
> avctx->height, colour1, colour2;
> [...]
> > +        unsigned int byte = *buf++, code = byte >> 6, length = byte &
> ~0xC0, offset;
>
> These would be more readable if they where not on a single line.
>
Done

-----------------
Sisir Koppaka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bfi_video_decoder_01.patch
Type: text/x-diff
Size: 7492 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080418/178cd6b3/attachment.patch>



More information about the ffmpeg-devel mailing list