[FFmpeg-devel] [PATCH] Decrease score returned by wav_probe

[Michael Niedermayer]

On Sat, Apr 19, 2008 at 09:18:08PM +0700, Vladimir Voroshilov wrote:
> Hi, Michael
> 
> On Sat, Apr 19, 2008 at 9:00 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sat, Apr 19, 2008 at 01:29:09PM +0700, Vladimir Voroshilov wrote:
> >  > Hi, All
> >  >
> >  > I've found recently that r12837 ("Do not detect a format if another
> >  > has the same score")
> >  > makes ACT format (uncommited, demuxer patch still pending in m/l for
> >  > G.729 decoder)
> >  > probing impossible .
> >  >
> >  > The reason is in standard WAV header placed at top of ACT's
> >  > This cause both ACT and WAV returns AVPROBE_SCORE_MAX which leads to
> >  > discarding probing results from both formats.
> >  >
> >  > Attached patch does tirival thing: decreases value returned by wav_probe by 1.
> >  > I'm not sure that this is correct solution, but can't see anything better.
> >  >
> >  > P.S. "make test" passed
> >
> >  patch ok, but please add a note why the score must be  < AVPROBE_SCORE_MAX
> >
> 
> Is text in attached patch good enough?

yes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080419/692efd3b/attachment.pgp>