[FFmpeg-devel] [PATCH] G.729 and G.729D decoders

Michael Niedermayer michaelni
Sun Apr 20 13:22:30 CEST 2008

On Sun, Apr 20, 2008 at 12:31:44PM +0700, Vladimir Voroshilov wrote:
> Hi, Michael.
> Thanks for quick answer.
> On Sun, Apr 20, 2008 at 5:03 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sun, Apr 20, 2008 at 12:41:26AM +0700, Vladimir Voroshilov wrote:
> >  > Hi, All again
> >  >
> [...]
> >  > g729h_15.diff - header
> >  > g729dec_15.diff.gz - decoder
> >  > g729tab_15.diff.gz - lookup tables
> >  > g729_build_15.diff - build part
> >  >
> >  > P.S. Files are gzipped due to overall size >80k
> >
> >  quick review of the non gziped parts is below
> >  i will review the rest as soon as i see a non compressed patch <100k
> >  which is selfcontained, that is it is usefull as it is, a header alone
> >  is not a selfcontanied patch it is useless as it is.
> I hope, lookup tables and build api can be separated.
> Otherwise i can't create uncompressed <100k patch.

Well this patch started out at 77k and then grew to 98k during review
now its even with compressed tables over 110k
77k is already very large and hard to review
Iam simply drawing a line and rejecting it until it returns to <100k
It was possible in previous iterations so it should still be. If not
which of my change requests caused such size increase?
You have added support for g729d thats nice but it has to be
split into a seperate patch. I dont know if it also makes sense to
split it into several files.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080420/bd8432b6/attachment.pgp>

More information about the ffmpeg-devel mailing list