[FFmpeg-devel] [PATCH]Add Dirac support to ffmpeg via libdirac_* and Schroedinger libraries]

[Luca Barbato]

Michael Niedermayer wrote:
> On Mon, Apr 21, 2008 at 09:16:19PM +1000, Anuradha Suraparaju wrote:
>> On Fri, 2008-04-18 at 15:23 +0200, Michael Niedermayer wrote:
>>> On Thu, Apr 17, 2008 at 09:18:57PM +1000, Anuradha Suraparaju wrote:
>>>> On Thu, 2008-04-10 at 15:33 +0200, Michael Niedermayer wrote:
>>>>> On Thu, Apr 10, 2008 at 05:56:21PM +1000, Anuradha Suraparaju wrote:
>>>>>> On Sat, 2008-04-05 at 01:44 +0200, Michael Niedermayer wrote:
>>>>>>
>>>>>>> [...]
>>>>>>>> diff --exclude=.svn -ruN ffmpegsvn_trunk/libavcodec/avcodec.h ffmpegsvn_trunk_dirac_schro/libavcodec/avcodec.h
>>>>>>>> --- ffmpegsvn_trunk/libavcodec/avcodec.h	2008-04-01 09:14:03.000000000 +1000
>>>>>>>> +++ ffmpegsvn_trunk_dirac_schro/libavcodec/avcodec.h	2008-04-01 09:15:43.000000000 +1000
>>>>>>>> @@ -182,6 +182,8 @@
>>>>>>>>      CODEC_ID_8SVX_EXP,
>>>>>>>>      CODEC_ID_8SVX_FIB,
>>>>>>>>      CODEC_ID_ESCAPE124,
>>>>>>>> +    CODEC_ID_SCHRO = 0xFFFE,
>>>>>>>> +    CODEC_ID_DIRAC = 0xFFFF,
>>>>>>> There should only be 1 codec_id and it should not have such a funny number.
>>>>>>> Also spliting dirac/schroedinger/common demuxer/parser/decoder/encoder in
>>>>>>> seperate patches would simplify review and likely reduce the number of
>>>>>>> review-patch-resend iteration needed to get the stuff in svn.
>>>>>>>
>>>>>>>
>>>>>> I've attached the dirac patch to this email. It does not include
>>>>>> dirac_parser.c as the GSoC code can be used without any changes. I've
>>>>>> created the patch using the latest svn revision 12780. I'll be mailing
>>>>>> the rest of the patches as soon as possible. 
>>>>> [...]
>>>> I've attached a patch of files common to the libdirac and
>>>> libschroedinger.
>>> [...]
>>>> +void ff_dirac_schro_queue_free (FfmpegDiracSchroQueue *queue,
>>>> +                                void (*free_func)(void *))
>>>> +{
>>>> +    while (queue->p_head) {
>>>> +        FfmpegDiracSchroQueueElement *top = queue->p_head;
>>>> +        queue->p_head = queue->p_head->next;
>>>> +        free_func(top->data);
>>>> +        av_freep(&top);
>>>> +    }
>>> following is simpler
>>>
>>> while (queue->p_head)
>>>     free_func( ff_dirac_schro_queue_pop(queue) );
>>>
>>> except that the patch looks ok
>>>
>>> [...]
>> New patch attached with this fix.
> 
> looks ok
> 

Committed.

lu

-- 

Luca Barbato
Gentoo Council Member
Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero