[FFmpeg-devel] [PATCH]Add Dirac support to ffmpeg via libdirac_* and Schroedinger libraries]

[Diego Biurrun]

On Thu, Apr 17, 2008 at 09:15:51PM +1000, Anuradha Suraparaju wrote:
> 
> I've attached the dirac patch to this email. I've created the patch
> using the latest svn version 12879.

...one more thing...

> --- ffmpegsvn_trunk/configure	2008-04-17 11:14:38.000000000 +1000
> +++ ffmpegsvn_trunk_dirac/configure	2008-04-17 20:43:10.000000000 +1000
> @@ -1618,6 +1622,7 @@
>  enabled libamr_wb  && require  libamrwb amrwb/dec_if.h D_IF_init -lamrwb -lm
> +enabled libdirac   && add_extralibs `pkg-config --libs dirac` "-lstdc++" && extraincs="$extraincs `pkg-config --cflags dirac`"

You are supposed to add a test with require/require2 here.  What you are
doing here will never fail, even if libdirac is not installed.

> @@ -2014,6 +2021,7 @@
>  fi
>  echo "LIB_INSTALL_EXTRA_CMD=${LIB_INSTALL_EXTRA_CMD}" >> config.mak
>  echo "EXTRALIBS=$extralibs" >> config.mak
> +echo "EXTRAINCS=$extraincs" >> config.mak
 
I maintain that this is unnecessary.  Just..

> --- ffmpegsvn_trunk/libavcodec/libdiracdec.c	1970-01-01 10:00:00.000000000 +1000
> +++ ffmpegsvn_trunk_dirac/libavcodec/libdiracdec.c	2008-04-17 16:26:59.000000000 +1000
> @@ -0,0 +1,211 @@
> +
> +#include <libdirac_decoder/dirac_parser.h>

.. prefix this with dirac/.

Diego