[FFmpeg-devel] [PATCH] pthread detection on mingw + static pthread

[Måns Rullgård]

Gianluigi Tiesi <mplayer at netfarm.it> writes:

> On Thu, Apr 24, 2008 at 09:33:29AM +0100, M?ns Rullg?rd wrote:
>> > It is necessary, but belongs in a separate patch. It checks not only
>> > that the x264_encoder_open symbols exists, but that we can actually
>> > link against this library.
>> 
>> The existing check seems to work just fine over here.  Do you know of
>> a real case where it is insufficient?  Besides, if people install
>> broken libraries, they can blame themselves.  After all, we don't (and
>> can't) verify that libraries we link against actually work.
>
> where needed -> mingw

Why?

> where not needed -> linux (also others, I've not tested)

This I know.

> libfaac uses the same check

I couldn't possibly care less.

>> This is better than the original patch, but I'm not entirely happy
>> with it.  Why can't the static pthread library do this in
>> pthread_create() instead?
>
> just curious but can I ask you the difference with mine?

I don't understand that question.

> the trick it's also required if you use mutex without using threads at all

Why would you use a mutex if you're not using threads?

> the home page:
> http://sourceware.org/pthreads-win32/
>
> you can ask directly to authors, but I doubt
> there is a better way to do this

Of course there's a better way.  Have the library entry points do the
necessary setup the first time one of them is called.  Feel free to
suggest this to the authors.  I'm not going to waste my time.

-- 
M?ns Rullg?rd
mans at mansr.com