[FFmpeg-devel] [PATCH] GSM-MS decoder and encoder

[Michel Bardiaux]

Baptiste Coudurier wrote:
> Hi,
> 
> Michel Bardiaux wrote:
>> Baptiste Coudurier wrote:
>>> Hi,
>>>
>>> [...]
>>>
>>> Can we please fix this ?
>>> http://samples.mplayerhq.hu/A-codecs/GSM/sample-gsm-8000.mov
>>>
>>> Choose whichever solution you prefer, but this sample should play
>>> without error message :>
>>>
>> Here is a 'permissive' first patch; 13000, 13200, and 0, are accepted
>> silently.
>>
[snip]

> Multiple frames in a packet from stream 0
>> [Repeated many many times]
>>
>> This is in ffmpeg.c:output_packet and seems to be due to weird pts'es
>> from input,
> 
> No, packet contains multiple frames, like error message says.
> 
> This illustrates another problem with libgsm decoder: data_size must be
> set to 0 before returning if nothing is output.
> 
> Also if buf_size < avctx->block_align you should return error (-1) here
> IMHO.
> 
Agreed. New patch for review.


-- 
Michel Bardiaux
http://www.mediaxim.com/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: gsm.pat
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080425/b15cc3ce/attachment.asc>