[FFmpeg-devel] [PATCH] Document libavcodec/opt.h

[Stefano Sabatini]

On date Wednesday 2008-04-23 01:07:49 +0200, Stefano Sabatini encoded:
> On date Tuesday 2008-04-08 11:57:23 +0200, Stefano Sabatini encoded:
> > Hi,
> > 
> > I had this in my working copy for months, I still have to review it
> > myself, I'll try to give it a check this night, so please await before
> > to review it yourself.
> 
> Hi, it takes more time than I thought to review it, and it looks quite
> an huge patch.
> 
> Note that I changed many of the parameters names, if you prefer I can
> provide a propedeutic patch with the corresponding changes (or
> eventually provide a patch to change accordingly opt.c after this if
> it will ever be applied).

[...]
> +/**
> + * Sets in \p ctx an option with the value contained in the string \p val.
> + *
> + * @param[in] ctx a pointer to an AVClass context
> + * @param[in] name the name of the option to be set
> + * @param[in] val a string containing the value to be parsed and set
> + * in \p ctx. The string is interpreted according to the type of the first
> + * matching option found in \p ctx.
> + * If \p val corresponds to a named value, then every option
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> + * @return a pointer corresponding to the option entry set or NULL if
> + * no option has been found <em>or</or> the value \p val <em>or</em>
> + * the option is not valid (for example if the option offset is <=0).
> + */
> +const AVOption *av_set_string(void *ctx, const char *name, const char *val);

Ouch! I missed this incomplete statement, I'm removing it as well as
the previous statement (I prefer to leave an indepth explanation of
av_set_string val value for another patch).

Regards.
-- 
FFmpeg =  Friendly Fucking Multimedia Porno EniGma
-------------- next part --------------
A non-text attachment was scrubbed...
Name: document-libavcodec-opt-h-02.patch
Type: text/x-diff
Size: 9982 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080426/de979793/attachment.patch>