[FFmpeg-devel] [PATCH] Support for variable frame duration

Baptiste Coudurier baptiste.coudurier
Sat Apr 26 14:06:01 CEST 2008


Henrik Gulbrandsen wrote:
> On Wed, 2008-04-23 at 00:19 +0200, Baptiste Coudurier wrote:
>> Hi,
>> Henrik Gulbrandsen wrote:
>> [...]
>> Better to get duration at the end when needed, thus removing computation
>> from the loop. Besides idea is ok.
> I think I may be missing your point. The only loop here iterates over
> about two streams,

Over s->nb_streams streams.

> so it's not like there is a performance issue, and
> the next_dts computation is where it is because that's where sample is
> determined in the first place. 

But it's not at all where we need and use this information.

> As far as I can see, there's no AVStream
> reference in MOVStreamContext, so I would have to save st in order to
> perform the computation outside the loop. Wouldn't this just introduce
> an unneeded variable and make the code harder to read?

I don't think so, s->streams[sc->ffindex].


Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312

More information about the ffmpeg-devel mailing list