[FFmpeg-devel] [PATCH] Common ACELP routines (3/3) - LPC decoding routines

Robert Swain robert.swain
Sat Apr 26 16:00:07 CEST 2008

On 26 Apr 2008, at 13:21, Vladimir Voroshilov wrote:
> On Sat, Apr 26, 2008 at 6:37 PM, Michael Niedermayer  
> <michaelni at gmx.at> wrote:
>> On Sat, Apr 26, 2008 at 02:18:17PM +0700, Vladimir Voroshilov wrote:
>>> P.S. Suggested commit message: "Fixed-point LSP and LPC decoding  
>>> routines for ACELP-based codecs"
>> ok
> Applied.

I apologise for spotting this after commit but I'm not sure how  
appropriate it is to have ff_acelp_lp_decode as a common function.  
Vladimir said it can be used for sipro but it's quite a simple function.

AMR-NB uses four subframe per frame, subframe 4 is always coded and  
subframe 2 is coded in some bit rate modes. I expect it probably  
differs in other ways in other acelp codecs so I'm not really sure  
it's worth having this shared, especially as it's a small amount of  


Also, I had a look through the two applied sets of code and looked for  
grammatical errors. I made the edits in the attached patch. Do they  
look OK?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20080426-acelp_grammar.diff
Type: application/octet-stream
Size: 2404 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080426/cc836b65/attachment.obj>
-------------- next part --------------

More information about the ffmpeg-devel mailing list