[FFmpeg-devel] [PATCH] Common ACELP routines (2/3) - filters
Sat Apr 26 20:05:07 CEST 2008
Thank you for your review.
On Sat, Apr 26, 2008 at 11:32 PM, Diego Biurrun <diego at biurrun.de> wrote:
> On Sat, Apr 26, 2008 at 11:11:56PM +0700, Vladimir Voroshilov wrote:
> > P.S. Please anybody check English spelling too.
> > --- /dev/null
> > +++ b/libavcodec/acelp_filters.c
> > @@ -0,0 +1,265 @@
> > +/**
> > + *
> > + * G.729 specification says:
> > + * b30 is based on Hamming windowed sinc functions, truncated at +/-29 and
> What's sinc?
Math function: y=sinc(x)=sin(x)/x
Widely used, imho
> > + // TODO: clarify why used such expression (hint: -1/3 , 0 ,1/3 order in interpol_filter)
> clarify why such an expression is used
Is comment in attached patch enough clear?
> > +/**
> > + * \brief Circularly convolve fixed vector with a phase dispersion impulse response filter
> "convolve" is not an English word. I have no idea what you are trying
> to say here.
"convolve" is a math term meaning something like "roll up" (not sure
about synonym though)
> > + * \param filter impulse response of phase filter to apply
> umm, ?
Changed to "phase filter coefficients"
> > + * \param speech [in/out] reconstructed speech signal for applying filter to
Changed to "speech data to proceed"
All thing not mentioned are fixed too.
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 13693 bytes
Desc: not available
More information about the ffmpeg-devel