[FFmpeg-devel] [PATCH] Fill unspecified AVCodec long_name fields

Stefano Sabatini stefano.sabatini-lala
Sun Apr 27 13:46:27 CEST 2008


On date Sunday 2008-04-27 13:00:27 +0200, Diego Biurrun encoded:
> On Sun, Apr 27, 2008 at 12:47:14PM +0200, Stefano Sabatini wrote:
> > On date Saturday 2008-04-26 18:55:33 +0200, Diego Biurrun encoded:
> > > On Sat, Apr 26, 2008 at 01:00:56PM +0200, Stefano Sabatini wrote:
> > [...]
> > > > --- libavcodec/rpza.c	(revision 12974)
> > > > +++ libavcodec/rpza.c	(working copy)
> > > > @@ -283,4 +283,5 @@
> > > >      CODEC_CAP_DR1,
> > > > +    .long_name = "Quicktime Video (RPZA)",
> > > 
> > > QuickTime video (RPZA)
> > > 
> > > Are you sure this name is correct?
> > 
> > Changed to: "QuickTime video (RPZA)", I found this reference to the
> > (joking) meaning of RPZA (Road Pizza):
> > http://www.mackido.com/EasterEggs/QuickTime.html
> > 
> > so it chould change to:
> > "QuickTime Road Pizza video",
> > 
> > Thanks for the huge review, new patch attached.
> > 
> > I also downcased some other instances of "Audio/Video" (for example im
> > MPEG Audio layer ...), and changed consistently:
> > 
> > Real {Audio|Video} version X.0 --> Real{Audio|Video} X.0
> > 
> > which seems more used (not sure if it is better though).
> 
> I already applied part of your patch to make reviewing easier before I
> saw this update, could you post a new version please?

Here it is, regards.
-- 
FFmpeg = Frightening Freak Merciless Porno EnGine
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-missing-long-names-05.patch
Type: text/x-diff
Size: 41271 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080427/d0dcef04/attachment.patch>



More information about the ffmpeg-devel mailing list