[FFmpeg-devel] [RFC PATCH] Mark ff_mlp_read_major_sync static.

Diego 'Flameeyes' Pettenò flameeyes
Wed Apr 30 18:04:42 CEST 2008

I'm not sure if this patch is okay. It marks ff_mlp_read_major_sync
static in mlp_parser.c and removes it from mlp_parser.h. This header is
only ever used in mlp_parser.c, but I'm not sure if it's there for
future extension or just because.

There are a few more cases where I see an internal .h declaring a
function used only in the related enc.c or in the dec.c. I'm not sure
what to do with those, I've tried locally to mark them static, and there
are interesting changes in the way gcc inlines or remove them entirely.

In this case I get:

  ff_mlp_read_major_sync | -733 (inlined)
  mlp_parse              | +619 # 753 -> 1372
 2 functions changed, 619 bytes added, 733 bytes removed, diff: -114

in other case the function is directly removed by the compiler once
marked static as it's not used anywhere, I can a list of those, if

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ff_mlp_read_major_sync-static.patch
Type: text/x-patch
Size: 1283 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080430/85d37093/attachment.bin>
-------------- next part --------------

Diego "Flameeyes" Petten?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080430/85d37093/attachment.pgp>

More information about the ffmpeg-devel mailing list