[FFmpeg-devel] [PATCH] Add SAMPLE_FMT_S24 audioconverter

Måns Rullgård mans
Mon Aug 4 15:42:52 CEST 2008


pross at xvid.org wrote:
> On Mon, Aug 04, 2008 at 08:29:10AM +0100, Ian Caulfield wrote:
>> 2008/8/4 madshi <dear at madshi.net>
>> >
>> > Michael Niedermayer schrieb:
>> >  > Iam against this patch.
>> >  > The code that stores 24bit PCM in int32_t should shift it
>> >  > left appropriately so it is SAMPLE_FMT_S32.
>
> Delete/deprecate SAMPLE_FMT_S24?
> And curiously, why was SAMPLE_FMT_U8 chosen over Signed 8-bit?

Unsigned 8-bit is far more common in the wild than signed.  I
can't remember ever seeing a file with signed 8-bit PCM audio.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list