[FFmpeg-devel] [VOTE] Multiple inclusion guards in headers

Diego Biurrun diego
Sun Aug 17 21:17:42 CEST 2008


On Sun, Aug 17, 2008 at 07:17:22PM +0200, Michael Niedermayer wrote:
> 
> Do we require headers that do not need multiple inclusion guards out of
> technical reasons to have multiple inclusion guards?

YES

> technical here is speed, compiler warnings or errors, or spec compliance

A technical reason is that sooner or later the headers change, need
guards and somebody promptly forgets them.  If you add them right away,
this category of bugs is avoided altogether.

> My vote is of course, no, as it makes the headers bigger and thus means
> more to read aka worse readability.

Nonsense, these are easily skipped visually.

Diego




More information about the ffmpeg-devel mailing list