[FFmpeg-devel] [PATCH] deprecate SAMPLE_FMT_S24
Tue Aug 19 14:42:30 CEST 2008
2008/8/19 Peter Ross <pross at xvid.org>:
> On Sun, Aug 17, 2008 at 05:10:39PM +0200, Michael Niedermayer wrote:
>> On Sun, Aug 17, 2008 at 04:37:49PM +0200, Aurelien Jacobs wrote:
>> > Michael Niedermayer wrote:
>> > > On Sun, Aug 17, 2008 at 03:32:30PM +0200, Aurelien Jacobs wrote:
>> > > > Peter Ross wrote:
>> > > >
>> > > > > This patch flags SAMPLE_FMT_S24 as deprecated.
>> > > >
>> bits_per_sample can NOT be used as SAMPLE_FMT_* bit count.
>> It has a different and docuented purpose, it describes the coded bitstream
>> and not the decoded samples, they match in bits only for lossless codecs.
>> the a demuxer sets bits_per_sample to 4 and passes the data to a ADPCM
>> decoder which has SAMPLE_FMT_S16 output with 13 significant bits the
>> last 3 being always 0
> Thanks for taking the time to explain this. Revised patch within.
> The proposed field make sense only for SAMPLE_FMT_S32. I've kept the language
> generic, as it will have future utility when FFmpeg can manipulate 12/16-bit
> luma planes.
It seems like SAMPLE_FMT_S16 with bits set to 12 would make sense,
even if I can't think of any cases where it might be used...
More information about the ffmpeg-devel