[FFmpeg-devel] [PATCH] Configure check for outdated x264 library

[Måns Rullgård]

Chris Hills <chaz at chaz6.com> writes:

> I have noticed a lot of people asking for help when compiling with an
> outdated version of x264. This patch checks for an outdated version
> and causes `configure` to fail as appropriate with a useful message.

The offending macro (X264_ME_TESA) has been around for 7 months.  It
is expected of users to have recent versions of libraries, especially
ones that are updated as frequently as x264.

> Index: configure
> ===================================================================
> --- configure	(revision 14845)
> +++ configure	(working copy)
> @@ -1725,6 +1725,17 @@
>      die "ERROR: No version of libdc1394 found "
>  fi
>
> +# x264 check
> +if enabled libx264; then
> +   check_cc <<EOF || die "Outdated version of x264 found. The minimum revision required is 728."
> +#include <stdint.h>
> +#include <x264.h>
> +int main(int argc, char **argv){
> +    int t = X264_ME_TESA;
> +    return 0;
> +}
> +EOF
> +fi

Rejected.

If we want to check for this, it should be done with a proper
check_xxx function.

-- 
M?ns Rullg?rd
mans at mansr.com