[FFmpeg-devel] [PATCH] Fix crash in libx264 when rc_eq is not set

Stefano Sabatini stefano.sabatini-lala
Wed Aug 20 14:07:40 CEST 2008


Hi,

check this thread:
http://thread.gmane.org/gmane.comp.video.ffmpeg.user/17920

The regression has been caused by r14788, rc_eq default value isn't
set in avcodec_get_context_defaults2(), while libx64 requires it to be
explicitely set.

This results libx264 encoding to crash when rc_eq is not explicitely
set.

Attached patch fixes the issue (but introduce a constness signature
related warning).

BTW I'm not satisfied by the way the default value of rc_eq is set as
a consequence of r14788, having the default value set in three
different places doesn't look that good.

Regards.
-- 
FFmpeg = Fast & Forgiving Multimedia Picky Ecletic Guru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-libx64-rc-eq-crash-00.patch
Type: text/x-diff
Size: 616 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080820/e21e81bf/attachment.patch>



More information about the ffmpeg-devel mailing list