[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [4/7] - G.729 core

Vladimir Voroshilov voroshil
Fri Aug 22 22:32:22 CEST 2008


2008/8/23 Michael Niedermayer <michaelni at gmx.at>:
> On Sat, Aug 23, 2008 at 01:41:58AM +0700, Vladimir Voroshilov wrote:
>> 2008/8/22 Michael Niedermayer <michaelni at gmx.at>:
>> > On Sun, Aug 17, 2008 at 05:42:33PM +0700, Vladimir Voroshilov wrote:
>>
>> [...]
>>
>> >> +    uint8_t ac_index_1st_bits;///< adaptive codebook index for first subframe (size in bits)
>> >> +    uint8_t ac_index_2nd_bits;///< adaptive codebook index for second subframe (size in bits)
>> >> +    uint8_t parity_bits;      ///< parity bit for pitch delay (size in bits)
>> >> +    uint8_t gc_1st_index_bits;///< gain codebook (first stage) index (size in bits)
>> >> +    uint8_t gc_2nd_index_bits;///< gain codebook (second stage) index (size in bits)
>> >> +    uint8_t fc_signs_bits;    ///< number of pulses in fixed-codebook vector
>> >> +    uint8_t fc_indexes_bits;  ///< size (in bits) of fixed-codebook index entry
>> >> +    /// mr_energy = mean_energy + 10 * log10(2^26  * subframe_size) in (7.13)
>> >> +    int mr_energy;
>> >> +} G729_format_description;
>> >
>> > as this is just used in the .c file it does not need to be in the header
>> > Also please move ALL other things from g729 headers into the corresponding
>> > .c files when they are ot used outside of a single c file.
>>
>> If i remove all such things (and will not yet care about encoder),
>> header will contain only one meanful line: "#define MAX_SUBFRAME_SIZE
>> 44" since only this definition is used in both g729dec.c and
>> g729postfilter.c.
>> I'm not sure that this is ok, but if it is, i'll make such patch.
>
> ok

Definitions were moved to g729dec.c and g729data.h
Values remaining in formats array differs from values used in G.729D.
I've also tried to remove most of useless comments.

-- 
Regards,
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 04_g729dec_87.diff
Type: text/x-diff
Size: 25514 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080823/ee81bdab/attachment.diff>



More information about the ffmpeg-devel mailing list