[FFmpeg-devel] Realmedia patch

[Luca Abeni]

Hi Ronald,

Ronald S. Bultje wrote:
[...]
> So I'll go for the small-patch path for parts that I think I can
> separate, I hope that helps. The attached patch adds the parse_header
> vfunc which I need because the RTSP packet header is different for RDT
> versus regular RTSP.

Just one quick question: why are you using the RTP demuxer for receiving
RDT (which seems to be a different thing)? Has this been requested during
a previous review? If yes, then I suspect your patch is ok (but I think
this makes the RTP code even more convoluted).
If no, then I suspect the best thing to do would be to add a new
"RTSP_PROTOCOL_RDT" protocol to RTSPProtocol, and to use it for calling
an "rdt_parse_packet()" instead of rtp_parse_packet().
Also, I think there are no RTCP-like packets with RDT, so
rtp_check_and_send_back_rr() should not be called, and the RTCP input
port should not be opened...


				Luca