[FFmpeg-devel] [PATCH] remove useless math.h include in libavutil/mathematics.h

[Reimar Döffinger]

On Mon, Aug 25, 2008 at 05:47:49PM +0200, Guillaume Poirier wrote:
> I noticed that the include of math.h in libavutil/mathematics.h doesn't
> seem to be usefull.

The point is that it can provide M_E etc. If you remove it and some code
(possibly indirectly) includes <math.h> after mathematics.h those will
be defined twice. I.e. removing it IMHO makes a mess.

> In file included from /usr/include/math.h:26,
>                 from ./libavutil/mathematics.h:25,
>                 from ./libavutil/avutil.h:57,
>                 from liba52/parse.c:40:
> /usr/include/architecture/ppc/math.h:179: error: parse error before
> '__attribute__'

Well, wtf is in math.h that it stumbles over?