[FFmpeg-devel] [PATCH] Fix crash in libx264 when rc_eq is not set
Mon Aug 25 20:21:25 CEST 2008
On Mon, 25 Aug 2008, M?ns Rullg?rd wrote:
> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
>> On date Monday 2008-08-25 17:41:05 +0200, Guillaume POIRIER encoded:
>>> no need to. x264 won't need rc_eq to be set in a few days...
>> But older libx264 versions will lye around for a long time, so IMO is
>> still a good idea to fix the problem.
> But we need to support the latest x264, which won't even have that
> field in the struct. What does old/current x264 do if it isn't
> touched at all?
x264_param_default sets rc_eq to a sane value. The problem only occurs
when ffmpeg overrides that and sets it to null. So removing the line from
ffmpeg will work with all x264 versions.
More information about the ffmpeg-devel