[FFmpeg-devel] Realmedia patch
Wed Aug 27 14:30:11 CEST 2008
Ronald S. Bultje wrote:
> Hi Aurel,
> On Wed, Aug 27, 2008 at 7:53 AM, Aurelien Jacobs <aurel at gnuage.org> wrote:
>> Ronald S. Bultje wrote:
>>> On Wed, Aug 27, 2008 at 2:34 AM, Diego Biurrun <diego at biurrun.de> wrote:
>>> > On Tue, Aug 26, 2008 at 09:38:03PM -0400, Ronald S. Bultje wrote:
>>> >> On Tue, Aug 26, 2008 at 9:34 PM, Aurelien Jacobs <aurel at gnuage.org>
>>> >> > avformat_internal.h ? The "avformat_" here is redundant. Just call
>>> >> > it internal.h.
>>> >> Won't that clash with lavutil/internal.h?
>>> > Since we require full #include paths for files from other directories,
>>> > i.e. '#include "libavutil/internal.h"', it really should not, unless
>>> > somebody has set -I flags. But people really should not...
>> We already have libavcodec/raw.h and libavformat/raw.h.
>> So people compiling FFmpeg with some stupid -I flags should be
>> prepared to surprises.
>>> lavu/common.h includes internal.h, not lavu/internal.h
>> So what ? internal.h will be searched in the same directory than the
>> file which included it, ie. lavu.
> OK, I didn't know that. Patch attached with your suggested modification then.
Is it really necessary to include this from avformat.h? Can't those files
that need the function #include the new header directly? I also think the
name "internal.h" is a bit too vague.
mans at mansr.com
More information about the ffmpeg-devel