[FFmpeg-devel] [PATCH] Fix some typos in avfilter.h

[Stefano Sabatini]

On date Wednesday 2008-08-27 06:51:53 -0400, The Wanderer encoded:
> M?ns Rullg?rd wrote:
> 
> > The Wanderer <inverseparadox at comcast.net> writes:
> > 
> >> M?ns Rullg?rd wrote:
> 
> >>> ^^ "but the output will always be the same format as the input"
> >> 
> >> This doesn't seem grammatical to me given the context of the phrase
> >> (and wouldn't really flow well even without that); the entire
> >> section after the final occurrence of the noun "filter" is in
> >> effect an adjective modifying that noun. I might paraphrase (not as
> >> a suggestion for actual use!) as something like "This is often true
> >> of a filter which, though it supports multiple formats, will always
> >> produce output which is in the same format as its input".
>
> > I disagree.  The word "but" starts a new independent clause, the
> > subject of which is "the output", implicitly understood to be that of
> > the filter discussed in the previous clause.
>
> I can see how you could interpret it that way, but it doesn't read that
> way to me; I would read your suggested form as being equivalent to
> "there may be references to the same list of formats, but the output
> will always be the same format as the input" - i.e., the part delimited
> by commas becomes marked as an aside which can be safely elided, which
> is not what I believe is meant.

Well maybe this is better but this is basically another issue, so I'll
drop it (feel free to open another thread if you want to discuss about
that).
 
> >>> "Also, a and b, and all references to either, will be
> >>> deallocated"

I don't like this for two reasons, first because it doesn't reflect
the temporal course of the operations performed in the code (which
frees all the references of x *then* x itself), and second for the use
of "to" instead of "of" (see below).

> >> "references to X" and "references of X" do not mean the same thing
> >> - the former indicates things which refer to X, the latter I would
> >> interpret as indicating things which are referred to by X.
> > 
> > Reading the original again, I can't quite figure out what it's trying
> > to say.
> 
> Neither could I, which is why I didn't change the word.

References are stored in {a|b}, so they aren't references *to* {a|b},
but references *of* them.

[...]

I'll apply tomorrow on evening unless... you know the rest ;-).

Regards.
-- 
FFmpeg = Foolish and Fantastic Minimal Purposeless Easy Gospel