[FFmpeg-devel] Realmedia patch

[Ronald S. Bultje]

Hi,

On Wed, Aug 27, 2008 at 10:29 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> On Wed, Aug 27, 2008 at 10:07 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> On Wed, Aug 27, 2008 at 09:06:44AM -0400, Ronald S. Bultje wrote:
>>> On Wed, Aug 27, 2008 at 8:43 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>>> > inOn Wed, Aug 27, 2008 at 08:39:11AM -0400, Ronald S. Bultje wrote:
>>> >> On Wed, Aug 27, 2008 at 8:27 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>>> >> > Let me try again :(
>>> >> >
>>> >> > ff_data_to_hex must not be in a public header not directly or indirectly.
>>> >> > NO public header must EVER include a non public header.
>>> >> > avformat.h is a public header
>>> >>
>>> >> Sorry, the same scheme is used in lavu/common.h, I just moved on from there...
>>> >
>>> > no
>>> >
>>> > lavu/common.h
>>> > uses:
>>> > #ifdef HAVE_AV_CONFIG_H
>>> > #    include "internal.h"
>>> > #endif /* HAVE_AV_CONFIG_H */
>>> >
>>> > So it only includes the internal header when common.h is used internally
>>>
>>> Same here, see grep HAVE_AV_CONFIG_H libavformat/avformat.h.
>>
>> hmm, true
>>
>> Still IMHO its clearer if internal.h is included directly instead of over
>> a public headetr when HAVE_AV_CONFIG_H is defined.
>
> OK, fine with me. If Mans doesn't like internal.h, I'll need
> suggestions for a name...

Well, I guess if there's no better name then I'll just stick to the
"vague" internal.h. :-). I'd request that naming-complaints are from
now accompanied by suggestions for better names, otherwise I really
don't know what to do with it to keep everyone happy.

Ronald
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sdp-export-data_to_hex.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080827/444fbd44/attachment.asc>