[FFmpeg-devel] DVCPRO HD: request for review

[Roman Shaposhnik]

This is an updated revision of the patch. I tried to take care of
all the comments that Michael made, except for this one:

> > +   /* 576i50 25Mbps 4:1:1 is a special case */
> > +   if (dsf == 1 && stype == 0 && frame[5] & 0x07) {
> > +       return &dv_profiles[2];
> > +   }
> 
> why is this special case needed ? cant it also be handled in the loop?

The special case is there to stay :-( The trouble is that I don't
have a spec for the twist of DV this is working around (IEC 61834)
and I can't see a reliable method for moving it inside the loop.

Thanks,
Roman.

P.S. I've also omitted the tables for ease of review.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.dvcprohd
Type: text/x-patch
Size: 24374 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080827/7cf4ce78/attachment.bin>