[FFmpeg-devel] [PATCH] QCELP decoder

Michael Niedermayer michaelni
Mon Dec 1 22:41:47 CET 2008


On Mon, Dec 01, 2008 at 01:20:13PM -0800, Kenan Gillet wrote:
> 
> On Dec 1, 2008, at 12:59 PM, Vitor Sessak wrote:
> 
> > Kenan Gillet wrote:
> >> Hi,
> >> On Mon, Dec 1, 2008 at 8:24 AM, Michael Niedermayer  
> >> <michaelni at gmx.at> wrote:
> >>> On Mon, Dec 01, 2008 at 08:17:52AM -0800, Kenan Gillet wrote:
> >>>> On Dec 1, 2008, at 4:52 AM, Michael Niedermayer wrote:
> >>>>
> >>>>> On Sun, Nov 30, 2008 at 05:04:07PM -0800, Kenan Gillet wrote:
> >>>>>> Hi,
> >>>>>> On Nov 30, 2008, at 7:50 AM, Michael Niedermayer wrote:
> >>>>>>
> >>>>>>> On Sat, Nov 29, 2008 at 10:39:58AM -0800, Kenan Gillet wrote:
> >>> [...]
> >>>>> [...]
> >>>>>>>> +    /**
> >>>>>>>> +     * reserved bits on all bitrate but bitrate 1/2 packets
> >>>>>>> this is unclear, field that is on all but ... , vs. field that
> >>>>>>> exists always but
> >>>>>>> is reserved on all but .....
> >>>>>>>
> >>>>>> is "reserved bits only set for bitrate 1, 1/4 and 1/8" better ?
> >>>>> no, because setting them means error IIRC
> >>>>> also IIRC there is no indication of the existence of other fields
> >>>>> for the
> >>>>> other rates ...
> >>>>>
> >>>> reserved bits only present in bitrate 1, 1/4 and 1/8 packets
> >>>>
> >>>> ?
> >>> ok
> >>>
> >>> [...]
> >>
> >> here is an updated round 14 of the patches,
> >> which is getting smaller and smaller :)
> >
> > Just a question:
> >
> > [...]
> >
> >> ===================================================================
> >> --- libavformat/mov.c	(revision 15972)
> >> +++ libavformat/mov.c	(working copy)
> >> @@ -988,6 +988,10 @@
> >> #endif
> >>     /* no ifdef since parameters are always those */
> >>     case CODEC_ID_QCELP:
> >> +        st->need_parsing = AVSTREAM_PARSE_FULL;
> >
> > Is this still needed?
> 
> all the samples files give the same wav output when removed.
> 
> I suppose it could be removed but I am no parser expert,
> so if somebody could confirm ?

if it works without then remove it


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081201/6884e020/attachment.pgp>



More information about the ffmpeg-devel mailing list