[FFmpeg-devel] [PATCH] add tag/comment support to the raw flac demuxer

Baptiste Coudurier baptiste.coudurier
Thu Dec 4 20:06:34 CET 2008


Michael Niedermayer wrote:
> On Mon, Dec 01, 2008 at 02:18:02PM -0800, Jim Radford wrote:
>> This patch adds support for parsing vorbis comments in plain flac
>> streams.  Only metadata packets are parsed leaving the frame data to
>> be parsed in raw 1024 byte chunks like before.
> this wont work with flac in any container short of raw flac.
> Thus IMO this is unacceptable

It's not like flac would be put in another container, except ogg and 
this would be a lot worse, and I personnally don't care about flac in ogg.

I guess 90% of flac files are lossless cd audio ripping scene, and in 
this case this patch really adds a feature which can be removed later if 
someone volonteer to do something at codec level.

This is IMHO acceptable, and I'd like it in svn.

Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no

More information about the ffmpeg-devel mailing list