[FFmpeg-devel] [PATCH] QCELP : warn for buf_size and bitrate mismatch only once
Fri Dec 5 13:09:54 CET 2008
On Thu, Dec 04, 2008 at 02:35:26PM -0800, Kenan Gillet wrote:
> at the moment this warning is logged for every frame,
> at AV_LOG_WARNING level.
> For at least 2 samples (h263.mov, blue_earth.mov),
> it creates an unnecessary long output.
> Should we demote it to AV_LOG_DEBUG or only show it once ?
> or only show it once like in the patch attached?
> Index: libavcodec/qcelpdec.c
> --- libavcodec/qcelpdec.c (revision 15997)
> +++ libavcodec/qcelpdec.c (working copy)
> @@ -69,6 +69,7 @@
> float pitch_gain;
> uint8_t pitch_lag;
> uint16_t first16bits;
> + uint16_t warn_buf_mismatch_bitrate;
you need exactly 16bits to store a flag?
also i think that warned, that is past tense or something is a better
choice than warn to make it clear that a "true" means it has been done
already. Instead of 1 meaning that the warning should still be printed
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel