[FFmpeg-devel] [PATCH] MP3: ID3V2 corrupted => bad offset

Yvan Labadie ylabadie
Fri Dec 5 16:08:11 CET 2008

M?ns Rullg?rd a ?crit :
> Michael Niedermayer wrote:
>> On Fri, Dec 05, 2008 at 02:18:03PM -0000, M?ns Rullg?rd wrote:
>>> [...]
>>> ID3v2.3 and earlier used a plain integer.  The "sync safe" encoding was
>>> introduced in v2.4.
>> that explains it, assuming all the failing files are < 2.4
>> a proper solution would then be to fix <2.4 support
Ooh! that kind of explains everything... :D

So I join a patch that uses the conversion corresponding to the version 
with a simple switch/case...
> That said, I wouldn't be very surprised if there are files out there
> with any kind of errors.  We're talking about mp3 files afters all...
Sure, so I should still do a check of mp3_parse_vbr_tags() and correct 
the offset if it fails... like we discuss in previous mail from Michael.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_mp3.diff
Type: text/x-patch
Size: 928 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081205/0d9abc23/attachment.bin>

More information about the ffmpeg-devel mailing list