[FFmpeg-devel] [PATCH] asf.c: move packet_time_start=0 statement

[Michael Niedermayer]

On Sat, Dec 06, 2008 at 10:20:05AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Thu, Dec 4, 2008 at 11:16 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > On Thu, Dec 4, 2008 at 10:34 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> On Thu, Dec 04, 2008 at 08:44:18AM -0500, Ronald S. Bultje wrote:
> >>> On Thu, Dec 4, 2008 at 8:17 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> >>> > Of course, I couldn't care less, but I wanted to refactor the piece of
> >>> > code that it comes from (in asf_read_packet()).
> >>
> >> i dont see how moving one of a dozen of lines from asf_read_packet() that sets
> >> packet_time_start into another function would be in any way clearer than it
> >> is now.
> >
> > There's 3 options:
> > - move it to asf_get_packet(), so it is done for both RTSP which calls
> > get/parse_packet() and for regular ASF files which use
> > asf_read_packet()
> > - move it with the rest into the wrapper function asf_read_packet(),
> > but then it is not done for RTSP, so not good
> > - make a second wrapper function, which is silly
> >
> > So I thought that moving it to asf_get_packet() was the cleanest way
> > of ensuring it is set to zero for both RTSP and for ASF files.
> 
> Any comments on this related to the first patch? I had similar patches
> approved for RTSP, if that matters any, to make RTSP/RDT easier...
> :-).

i dont like the move currently, so id say postponed until the 2 lines
of code it is said to simplify are in svn.


> 
> > So you want me to remove them (in a separate patch, of course)? I
> > mean, even av_log(DEBUG) is stupid for this kind of cruft, I don't
> > want it enabled for regular playback, ever.
> 
> And same here, remove in separate patch or something else?

remove in a seperate patch yes

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081206/99768b9c/attachment.pgp>