[FFmpeg-devel] [PATCH] AAC: unroll parts of decode_spectrum_and_dequant()
Tue Dec 9 17:47:00 CET 2008
On Tue, Dec 9, 2008 at 6:39 AM, Robert Swain <robert.swain at gmail.com> wrote:
> 2008/12/9 Alex Converse <alex.converse at gmail.com>:
> > On Mon, Dec 8, 2008 at 10:58 PM, Jason Garrett-Glaser <
> darkshikari at gmail.com
> >> if (vq_ptr) coef[coef_tmp_idx + 2] = 1 - 2*(int)get_bits1(gb);
> >> if (vq_ptr) coef[coef_tmp_idx + 3] = 1 - 2*(int)get_bits1(gb);
> >> Isn't that a rather unnecessary int -> float conversion? I'd think
> >> you could do much better than that considering there are only two
> >> possible input values...
> > In principle I agree. In practice is that a non germane change that needs
> > be in a segregated patch? I had an improvement for ESC_BT that I tossed
> in a
> > separate patch.
> If it's unrelated, stick it in a separate patch. If you're unsure, it
> won't hurt to put it in a separate patch as it looks like a different
> style of potential micro-optimisation.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1618 bytes
Desc: not available
More information about the ffmpeg-devel