[FFmpeg-devel] Various small fixes

Diego Biurrun diego
Sat Dec 13 13:49:55 CET 2008


On Sat, Dec 13, 2008 at 01:34:27PM +0100, Anders Gr?nberg wrote:
> I have been experimenting with FFmpeg and this patch fixes some small
> issues I found in the code base that should be beneficial to other
> FFmpeg developers.

Send separate patches for separate issues please, you will see them get
applied quicker in this way.

Also, some explanations for your changes would be helpful.

> --- libavcodec/imgconvert.h	(revision 16089)
> +++ libavcodec/imgconvert.h	(working copy)
> @@ -27,6 +27,8 @@
>  #include <stdint.h>
>  #include "avcodec.h"
>  
> +int img_convert(AVPicture *dst, int dst_pix_fmt, const AVPicture *src, int src_pix_fmt, int src_width, int src_height);
> +
>  int ff_fill_linesize(AVPicture *picture, int pix_fmt, int width);
>  
>  int ff_fill_pointer(AVPicture *picture, uint8_t *ptr, int pix_fmt, int height);
> --- libavcodec/imgresample.c	(revision 16089)
> +++ libavcodec/imgresample.c	(working copy)
> @@ -27,6 +27,7 @@
>  #include "avcodec.h"
>  #include "dsputil.h"
>  #include "libswscale/swscale.h"
> +#include "imgconvert.h"

I noticed this issue as well, this part will get applied in a moment.

> --- libavformat/Makefile	(revision 16089)
> +++ libavformat/Makefile	(working copy)
> @@ -82,8 +82,8 @@
>  OBJS-$(CONFIG_MATROSKA_AUDIO_MUXER)      += matroskaenc.o matroska.o riff.o avc.o
> -OBJS-$(CONFIG_MATROSKA_DEMUXER)          += matroskadec.o matroska.o riff.o
> -OBJS-$(CONFIG_MATROSKA_MUXER)            += matroskaenc.o matroska.o riff.o avc.o
> +OBJS-$(CONFIG_MATROSKA_DEMUXER)          += matroskadec.o matroska.o riff.o isom.o
> +OBJS-$(CONFIG_MATROSKA_MUXER)            += matroskaenc.o matroska.o riff.o avc.o isom.o

You missed MATROSKA_AUDIO_MUXER.  Anyway, applied.

Diego




More information about the ffmpeg-devel mailing list