[FFmpeg-devel] [PATCH 0/2] Fix strict aliasing violations in AAC and AC3 parsers

[Jason Garrett-Glaser]

> I meant to suggest to add it to files that fail without instead of
> spending significant time working around each issue.
>
> But iam not against adding it globaly if someone benchmarked the major
> codecs with it.

Test clip: http://mirror05.x264.nl/Dark/x264clips/BigBuckBunny.mkv (1080p H.264)
Test command: -benchmark -y -i BigBugBunny.mkv -an -f null /dev/null
CPU: Nehalem
OS: Gentoo 64-bit

FFmpeg version SVN-r16140, Copyright (c) 2000-2008 Fabrice Bellard, et al.
  configuration: --extra-cflags=-fno-strict-aliasing
  built on Dec 14 2008 17:17:59, gcc: 4.3.2

bench: utime=245.196s
bench: utime=244.957s

Oprofile:

40651    16.5607  ffmpeg_g_no              ffmpeg_g_no              filter_mb
25477    10.3790  ffmpeg_g_no              ffmpeg_g_no              fill_caches
25321    10.3154  ffmpeg_g_no              ffmpeg_g_no
hl_decode_mb_simple
11555     4.7074  ffmpeg_g_no              ffmpeg_g_no
decode_mb_cabac
9516      3.8767  ffmpeg_g_no              ffmpeg_g_no
put_h264_chroma_mc8_ssse3_rnd
8067      3.2864  ffmpeg_g_no              ffmpeg_g_no              mc_part
7928      3.2298  ffmpeg_g_no              ffmpeg_g_no
decode_mb_skip
7818      3.1849  ffmpeg_g_no              ffmpeg_g_no
decode_cabac_residual_nondc
7753      3.1585  ffmpeg_g_no              ffmpeg_g_no
pred_direct_motion
7285      2.9678  ffmpeg_g_no              ffmpeg_g_no
get_cabac_noinline
7206      2.9356  ffmpeg_g_no              ffmpeg_g_no
prefetch_mmx2
6787      2.7649  ffmpeg_g_no              ffmpeg_g_no
clear_blocks_mmx
6656      2.7116  ffmpeg_g_no              ffmpeg_g_no
put_h264_qpel8or16_v_lowpass_sse2
6035      2.4586  ffmpeg_g_no              ffmpeg_g_no
h264_h_loop_filter_luma_mmx2
5264      2.1445  ffmpeg_g_no              ffmpeg_g_no
decode_cabac_mb_mvd
5047      2.0561  ffmpeg_g_no              ffmpeg_g_no              hl_motion
5019      2.0447  ffmpeg_g_no              ffmpeg_g_no
put_h264_qpel8or16_hv_lowpass_ssse3

FFmpeg version SVN-r16140, Copyright (c) 2000-2008 Fabrice Bellard, et al.
  configuration:
  built on Dec 14 2008 17:19:10, gcc: 4.3.2

bench: utime=287.234s
bench: utime=286.712s

Oprofile:

41282    14.3816  ffmpeg_g                 ffmpeg_g                 filter_mb
32030    11.1585  ffmpeg_g                 ffmpeg_g
hl_decode_mb_simple
26807     9.3389  ffmpeg_g                 ffmpeg_g                 fill_caches
15244     5.3106  ffmpeg_g                 ffmpeg_g
decode_mb_skip
13646     4.7539  ffmpeg_g                 ffmpeg_g
decode_mb_cabac
12271     4.2749  ffmpeg_g                 ffmpeg_g
put_h264_chroma_mc8_ssse3_rnd
11767     4.0993  ffmpeg_g                 ffmpeg_g
get_cabac_noinline
10519     3.6646  ffmpeg_g                 ffmpeg_g
prefetch_mmx2
9690      3.3758  ffmpeg_g                 ffmpeg_g
pred_direct_motion
8598      2.9953  ffmpeg_g                 ffmpeg_g
put_h264_qpel8or16_v_lowpass_sse2
8074      2.8128  ffmpeg_g                 ffmpeg_g                 mc_part
7866      2.7403  ffmpeg_g                 ffmpeg_g
decode_cabac_residual_nondc
6434      2.2414  ffmpeg_g                 ffmpeg_g
clear_blocks_mmx
6125      2.1338  ffmpeg_g                 ffmpeg_g
put_h264_qpel16_h_lowpass_l2_ssse3
6092      2.1223  ffmpeg_g                 ffmpeg_g
put_h264_qpel8or16_hv_lowpass_ssse3
5900      2.0554  ffmpeg_g                 ffmpeg_g
h264_h_loop_filter_luma_mmx2

Dark Shikari