[FFmpeg-devel] [PATCH] Fix opt_default()

[Stefano Sabatini]

On date Tuesday 2008-12-16 18:24:21 +0100, Michael Niedermayer encoded:
> On Tue, Dec 16, 2008 at 09:14:06AM +0100, Stefano Sabatini wrote:
[...]
> > I think it is better to follow the path:
> > * define the new function;
> > * replace all the uses of the old function
> > * deprecate + ifdef the old function
> > 
> > implemented by the patchset.
> > 
> > And I think that if you want to ifdef a function then you have also to
> > deprecate it, so is nicer to first remove the old function use thus
> > avoiding warnings.
> > 
> > But if you prefer the other way (define av_set_string3() *and*
> > ifdef/deprecate av_set_string2() at once) I'm fine with it too.
> 
> i prefer to mark the old as deprecated when the new is added because
> that is the point where it is deprecated, not once it isnt used anywhere
> anymore.
> the "deprecated" gives a nice reminder so its not forgotten, when its
> done seperately it can easily be forgotten.

Sorry to bother again, I promise this is the last time (at least in
this thread)...

So what about:
1) define the new function *and* deprecate the old one
2) replace all the old function uses
3) ifdef the old function

Rationale: deprecated functions shouldn't be iff'ed when they're
still used in the project code.

Regards.
-- 
FFmpeg = Faboulous and Freak Marvellous Prodigious Educated Geisha
-------------- next part --------------
A non-text attachment was scrubbed...
Name: implement-av-set-string3.patch
Type: text/x-diff
Size: 4638 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081216/4d83fb27/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-opt-default.patch
Type: text/x-diff
Size: 1902 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081216/4d83fb27/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: use-av-set-string3.patch
Type: text/x-diff
Size: 1892 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081216/4d83fb27/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: replace-o2.patch
Type: text/x-diff
Size: 551 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081216/4d83fb27/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ifdef-av-set-string12.patch
Type: text/x-diff
Size: 1324 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081216/4d83fb27/attachment-0004.patch>