[FFmpeg-devel] [PATCH] Port x264 SSE2 deblocking code to H.264 decoder

Jason Garrett-Glaser darkshikari
Wed Dec 17 01:56:52 CET 2008

On Tue, Dec 16, 2008 at 3:06 PM, Guillaume POIRIER <poirierg at gmail.com> wrote:
> Hello,
> On Tue, Dec 16, 2008 at 11:07 PM, M?ns Rullg?rd <mans at mansr.com> wrote:
>>> +#if defined(CONFIG_GPL) && defined(HAVE_YASM)
> Since basicly only Loren and yourself have worked on that code, maybe
> you'd both be willing to re-licence it in LGPL?

I haven't done anything significant to deblock--it's purely Loren's
code, so he's the one to ask about this.

> I belive that whatever license header this file shall carry, it should not
> differ between the file in x264 and ffmpeg.

I just copied the one from ffmpeg used in the ac3 encoder.

> why?

I was copying the syntax used in dsputil_yasm.asm.

> would it be possible to use some kind of macro to give these functions
> differnt prefixes so the .asm files could be identical?

Or you could just let us call them "x264"...

> why is all this code ommited?

The MMXEXT code is omitted because ffh264 already has mmxext
implementations of those which are quite similar, so I figured there
was no point in wasting code space (as the ffh264 are LGPL and
therefore preferred).

I skipped luma_intra for now as I saw no asm implementation at all in
ffh264, but yes, I should probably add that back in.

Dark Shikari

More information about the ffmpeg-devel mailing list