[FFmpeg-devel] [PATCH 0/2] Fix strict aliasing violations in AAC and AC3 parsers
Wed Dec 17 02:42:25 CET 2008
M?ns Rullg?rd <mans at mansr.com> writes:
> Michael Niedermayer <michaelni at gmx.at> writes:
>> On Sun, Dec 14, 2008 at 08:53:16PM +0000, Mans Rullgard wrote:
>>> The AAC and AC3 parsers both violate strict aliasing rules when using
>>> a uint64_t variable as buffer for the bitstream reader. Although I am
>>> not entirely certain of the strict validity of these patches, they are
>>> sufficient to make gcc do the right thing, and they can't make things
>>> any worse.
>>> Please comment.
>> ive no objections to these patches, though personally id rather add
>> -fno-strict-aliasing to the flags of these 2 files ...
> I'd rather have correct code than rely on compiler flags altering the
> semantics of the language.
So is it OK to apply these patches. They fix things that are broken
mans at mansr.com
More information about the ffmpeg-devel