[FFmpeg-devel] [PATCH] Add missing input buffer padding to h264/mkv

[Aurelien Jacobs]

Alexander Strange wrote:

> This fixes the large number of valgrind warnings I get printed  
> decoding h264+mkv, by adding input buffer padding where the bitstream  
> readers need it. No speed change.
> 
> [...]
> 
> Index: libavformat/matroskadec.c
> ===================================================================
> --- libavformat/matroskadec.c	(revision 16074)
> +++ libavformat/matroskadec.c	(working copy)
> @@ -1304,7 +1304,7 @@
>              st->codec->extradata = extradata;
>              st->codec->extradata_size = extradata_size;
>          } else if(track->codec_priv.data && track->codec_priv.size > 0){
> -            st->codec->extradata = av_malloc(track->codec_priv.size);
> +            st->codec->extradata = av_mallocz(track->codec_priv.size+FF_INPUT_BUFFER_PADDING_SIZE);
>              if(st->codec->extradata == NULL)
>                  return AVERROR(ENOMEM);
>              st->codec->extradata_size = track->codec_priv.size;

OK with the +FF_INPUT_BUFFER_PADDING_SIZE on its own line to fit
80 cols...

Aurel