[FFmpeg-devel] [PATCH]Silence icc warnings
Sun Dec 21 22:21:34 CET 2008
On Sun, Dec 21, 2008 at 09:03:59PM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> > > Index: libavutil/common.h
> > > ===================================================================
> > > --- libavutil/common.h (revision 16246)
> > > +++ libavutil/common.h (working copy)
> > > @@ -76,7 +76,7 @@
> > > #endif
> > >
> > > #ifndef av_cold
> > > -#if AV_GCC_VERSION_AT_LEAST(4,3)
> > > +#if !defined(__ICC) && AV_GCC_VERSION_AT_LEAST(4,3)
> > these things should be
> > AV_GCC_VERSION_AT_LEAST() || AV_ICC_VERSION_AT_LEAST()
> No, that would not work because icc sets __GCC__ (and additionally, it sets it
> differently depending on /usr/bin/gcc on the system it gets installed).
> For all three cases, currently, all known icc versions fail: I tested the newest
> one (and older ones).
i wonder if AV_GCC_VERSION_AT_LEAST(X,Y) should return true for ICC when
ICC does not really support all features of gcc X.Y
> May I apply the patch?
the problem is that, with this patch and icc eventually adding support
this will certainly be forgotten.
OTOH a AV_ICC_VERSION_AT_LEAST() based check that lists the latest version
that is known not to support it + 1, it would not be forgotten it would just
be a little annoying
this could also be done like
(!defined(__ICC) && AV_GCC_VERSION_AT_LEAST()) || AV_ICC_VERSION_AT_LEAST()
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel