[FFmpeg-devel] [RFC]Possible problem in avio.c

[Carl Eugen Hoyos]

Michael Niedermayer <michaelni <at> gmx.at> writes:

[...]

> > > init_put_byte() calls url_resetbuf() before initializing s->opaque.
> > > Then url_resetbuf() access s->opaque as a URLContext pointer...
> > > So init_put_byte() should really initialize s->opaque before
> > > calling url_resetbuf().
> > > See attached patch.
> > 
> > The patch fixes the crashes for me!
> > 
> > Michael, you are maintainer, is the patch ok?
> 
> yes

Patch applied.
After compilation with icc 10.1 (64bit), regression tests pass (except for the
wmav2 difference that I also see with gcc on my computer) and h264 decoding also
works.

Thank you, Carl Eugen