[FFmpeg-devel] [PATCH] powerpc --> ppc

Guillaume POIRIER poirierg
Sat Dec 27 01:49:27 CET 2008


Hello,

On Fri, Dec 26, 2008 at 11:29 PM, Diego Biurrun <diego at biurrun.de> wrote:
> On Thu, Dec 25, 2008 at 05:02:55PM +0100, Guillaume POIRIER wrote:
>>
>> On Thu, Dec 25, 2008 at 3:10 PM, Diego Biurrun <diego at biurrun.de> wrote:
>> > There is some inconsistency in the way we handle the naming of the
>> > PowerPC/PPC architecture right now.  Sometimes it is powerpc, sometimes
>> > ppc.  I suggest we go for ppc, which we also use as subdirectory name.
>> > $attached implements this and will help me with some build system
>> > changes in the future.
>>
>> I support this change.
>
> Luca, what do you say?
>
>> > Another thing I noticed: What is ARCH_POWERPC_405?  It is never set...
>>
>> This was added by this _very old_ commit:
>>
>> commit 45c7805311002362b42e98a664419bfe8ff23931
>> Author: bellard <bellard at 9553f0bf-9b14-0410-a0b8-cfaf0461ba5b>
>> Date:   Wed Jun 5 14:25:06 2002 +0000
>>
>>     removed unused code - began to merge alpha specific stuff - added
>> mac macros for suitable CPUs
>>
>>     git-svn-id: file:///var/local/repositories/ffmpeg/trunk at 667
>> 9553f0bf-9b14-0410-a0b8-cfaf0461ba5b
>
> That's just the one in simple_idct.c, the one in ppc/mathops.h is from
> September 2006.

It's older than that: it was in libavcodec/mpegaudiodec.c before, as
this commit shows:
http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/2006-August/003283.html


Guillaume
-- 
Only a very small fraction of our DNA does anything; the rest is all
comments and ifdefs.

Henny Youngman  - "If at first you don't succeed... so much for skydiving."




More information about the ffmpeg-devel mailing list